[
https://issues.apache.org/jira/browse/THRIFT-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053892#comment-14053892
]
Ben Craig commented on THRIFT-2416:
-----------------------------------
The attached patch looks fine to me (though I haven't tested). +1.
When the MSVC + ARM developers complain, they can put the appropriate code
behind an _M_ARM guard.
> Cannot use TCompactProtocol with MSVC
> -------------------------------------
>
> Key: THRIFT-2416
> URL: https://issues.apache.org/jira/browse/THRIFT-2416
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.1
> Environment: MSVC 11
> Reporter: Chris Stylianou
> Labels: c++, msvc, thrift
> Attachments: THRIFT-2416.patch
>
>
> Cannot use TCompactProtocol with MSVC as it appears that
> SIGNED_RIGHT_SHIFT_IS and ARITHMETIC_RIGHT_SHIFT are not defined.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
