Github user ruijiang commented on the pull request:
https://github.com/apache/thrift/pull/161#issuecomment-49975154
Thanks for the review. This turns out to be harder than I thought. The main
issue is dealing with two states:
--Whether the bit is set.
--Whether the member is null or not.
If we define isSetX() to be either of these or both, it might cause some
existing corner cases to break. I will close this PR until I have better
solution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
