[
https://issues.apache.org/jira/browse/THRIFT-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom Lee updated THRIFT-2637:
----------------------------
Attachment: fullcamel_service_methods-v3.patch
Looks like this file is using both 2 and 4 space indentation in various places
(e.g. make_valid_java_identifier and make_valid_java_filename, the former
appears to be what inspired me to use 4 space indentation). Here's an updated
patch with 2 space indentation for the methods you mentioned all the same.
I'll try to find time over the weekend to clean up the whitespace in this file,
but that's one for another JIRA ticket. Thanks!
> "java:fullcamel_service_methods" option to automatically camel-case Java
> service methods
> ----------------------------------------------------------------------------------------
>
> Key: THRIFT-2637
> URL: https://issues.apache.org/jira/browse/THRIFT-2637
> Project: Thrift
> Issue Type: New Feature
> Components: Java - Compiler
> Affects Versions: 0.9.2
> Reporter: Tom Lee
> Priority: Minor
> Attachments: fullcamel_service_methods-v2.patch,
> fullcamel_service_methods-v3.patch, fullcamel_service_methods.patch
>
>
> [~roger.meier] I hope this isn't too late for the 0.9.2 RC, but it occurred
> to me recently that the java:fullcamel feature which landed in THRIFT-2469
> was only half the picture for Java developers consuming Thrift services from
> other languages. Specifically, accessors would look as you might expect using
> java:fullcamel, but service methods will remain untouched.
> This patch will modify the compiler to add a new option --
> java:fullcamel_service_methods -- which will cause service methods to be
> exposed as camelCase methods. For example: a service method called
> foo_bar_baz becomes fooBarBaz at the source level, while maintaining
> protocol-level compatibility.
> I pondered simply making this the default behavior of the java:fullcamel
> option & simply omitting the new option -- easy enough change to make if
> those semantics are preferred.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
