[
https://issues.apache.org/jira/browse/THRIFT-585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell reopened THRIFT-585:
---------------------------------
Reverting 8345772f299a308496ebaae6516f3f813469f829 from PR 165 in trunk for the
0.9.2-rc1 as it breaks test suite by generating invalid code in
test/ThriftTest.thrift for the py.twisted tests
{code}
vagrant@vagrant-ubuntu-trusty-64:/thrift/test/py.twisted$ make check
../../compiler/cpp/thrift --gen py:twisted ../ThriftTest.thrift
[WARNING:/thrift/test/ThriftTest.thrift:42] No generator named 'noexist' could
be found!
[WARNING:/thrift/test/ThriftTest.thrift:43] cpp generator does not accept
'noexist' as sub-namespace!
../../compiler/cpp/thrift --gen py:twisted ../SmallTest.thrift
[WARNING:/thrift/test/SmallTest.thrift:27] "senum" is deprecated and will be
removed in a future compiler version. This type should be replaced with
"string".
[WARNING:/thrift/test/SmallTest.thrift:27] "senum" is deprecated and will be
removed in a future compiler version. This type should be replaced with
"string".
/usr/bin/trial test_suite.py
test_suite
py ... [ERROR]
===============================================================================
[ERROR]
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/twisted/trial/runner.py", line 586, in
loadByNames
things.append(self.findByName(name))
File "/usr/lib/python2.7/dist-packages/twisted/trial/runner.py", line 395, in
findByName
return filenameToModule(name)
File "/usr/lib/python2.7/dist-packages/twisted/trial/runner.py", line 84, in
filenameToModule
ret = reflect.namedAny(reflect.filenameToModuleName(fn))
File "/usr/lib/python2.7/dist-packages/twisted/python/_reflectpy3.py", line
266, in namedAny
topLevelPackage = _importAndCheckStack(trialname)
File "/usr/lib/python2.7/dist-packages/twisted/python/_reflectpy3.py", line
205, in _importAndCheckStack
return __import__(importName)
File "/thrift/test/py.twisted/test_suite.py", line 24, in <module>
from ThriftTest import ThriftTest
exceptions.SyntaxError: invalid syntax (ThriftTest.py, line 1269)
{code}
> exceptions in the autogenerated send_METHOD functions are not propagated
> (Twisted)
> ----------------------------------------------------------------------------------
>
> Key: THRIFT-585
> URL: https://issues.apache.org/jira/browse/THRIFT-585
> Project: Thrift
> Issue Type: Bug
> Components: Python - Compiler, Python - Library
> Reporter: Esteve Fernandez
> Assignee: Jens Geyer
> Fix For: 0.9.2
>
> Attachments: 585-handle-send-exceptions.patch,
> ASF.LICENSE.NOT.GRANTED--t_py_generator.cc
>
>
> If an error occurs in the autogenerated send_METHOD functions, the returned
> deferred is not notified and the caller can't manage the error.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
