[
https://issues.apache.org/jira/browse/THRIFT-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078767#comment-14078767
]
Brent Pearson commented on THRIFT-1552:
---------------------------------------
Now when I try to do the following, I get errors because the -I include path
still has the trailing "thrift":
cd <THRIFT_ROOT>/contrib/fb303
BOOST_ROOT=<BOOST_ROOT>
PY_PREFIX=<THRIFT_ROOT>/contrib/fb303/install
CFLAGS="-fPIC -DHAVE_INTTYPES_H -DHAVE_NETINET_IN_H" CPPFLAGS="-fPIC
-DHAVE_INTTYPES_H -DHAVE_NETINET_IN_H"
./bootstrap.sh --with-thriftpath=<THRIFT_ROOT>/install
-prefix=<THRIFT_ROOT>/contrib/fb303/install && \
make install
I had to change
AM_CPPFLAGS += -I$(thrift_home)/include/thrift
to
AM_CPPFLAGS += -I$(thrift_home)/include
in <THRIFT_ROOT>/contrib/fb303/cpp/Makefile.am
> Thrift (cpp) include files shouldn't require adding "thrift" to the compilers
> include path.
> -------------------------------------------------------------------------------------------
>
> Key: THRIFT-1552
> URL: https://issues.apache.org/jira/browse/THRIFT-1552
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Compiler, C++ - Library
> Affects Versions: 0.8
> Environment: All
> Reporter: Ricky Cormier
> Assignee: Ricky Cormier
> Labels: cpp, include, path
> Attachments:
> THRIFT-1552-Include-paths-for-c-and-cpp-should-be-prefixed-with-thrift.patch,
> THRIFT-1552-Include-paths-for-c-and-cpp-should-be-prefixed-with-thrift.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> When including thrift header files it is necessary to add thrift to the
> compilers include path. Headers are then included something like this...
> #include <thrift.h>
> #include <server/TNonblockingServer.h>
> #include <protocol/TBinaryProtocol.h>
> ... and so on.
> It is generally preferable to have include paths prefixed with the name of
> the library to which they belong. This not only prevents the possibility of
> include ambiguity it also acts as documentations and aids readability.
> This changes is to allow the header files to be included with "thrift" as the
> leading path leaf...
> #include <thrift/thrift.h>
> #include <thrift/server/TNonblockingServer.h>
> #include <thrift/protocol/TBinaryProtocol.h>
> We have already made this change to our version of thrift-0.5.0 and I am
> currently working on patching this change to trunk.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
