[
https://issues.apache.org/jira/browse/THRIFT-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085434#comment-14085434
]
Roger Meier commented on THRIFT-2641:
-------------------------------------
Hi Noam
thanks for the patch! a large meal...
I agree with John, smaller units are much easier to handle.
However, there is lot of stuff which is really beneficial for Thrift users.
I will try to handle this meal together with [~cheecheeo].
here are some comments:
- lot of nice cleanup work!
- compact and json is great!
- cross language test suite integration, could you provide some TestServer and
TestClient according to http://thrift.apache.org/test/ to ensure cross language
compatibility
- please do not change version within lib/hs/Thrift.cabal
test is in progress...
thanks
roger
> Improvements to Haskell Compiler/Libraries
> ------------------------------------------
>
> Key: THRIFT-2641
> URL: https://issues.apache.org/jira/browse/THRIFT-2641
> Project: Thrift
> Issue Type: Improvement
> Components: Haskell - Compiler, Haskell - Library, Test Suite
> Reporter: Noam Zilberstein
> Assignee: Roger Meier
>
> I work at Facebook and have spent the last couple months improving the
> Haskell compiler and libraries for Thrift. I have made significant
> improvements in terms of usability and performance and I would like to share
> those improvements with the Apache open source community. Right now I am
> working on the final touches and will be able to submit a patch in the next
> few days
--
This message was sent by Atlassian JIRA
(v6.2#6252)
