GitHub user jamesbroadhead opened a pull request:
https://github.com/apache/thrift/pull/181
Fix spurious test failures in py:twisted
- py.twisted/test_suite.py:ThriftTestCase.testOneway relies on
testOneWay executing in less than 0.04 seconds (since it sleeps for 2
seconds, then asserts that 2s - <time> ~= 0). On slow, or loaded
machines this may fail. Switch this to sleep for 1 second, then have a
tolerance of 0.4s for the deferred resolution.
- Removes a dud return d from testOneWay.
- Remove '*' import & dud 'import random'. This file now passes
pyflakes.
- Strip trailing whitespace
Jira: THRIFT-2657
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jamesbroadhead/thrift
twisted_spurious_test_failures
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/181.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #181
----
commit aa917a6098b4516deda3a91d33eef6b9bbcd0791
Author: James Broadhead <[email protected]>
Date: 2014-08-09T17:21:44Z
Fix spurious test failures in py:twisted
- py.twisted/test_suite.py:ThriftTestCase.testOneway relies on
testOneWay executing in less than 0.04 seconds (since it sleeps for 2
seconds, then asserts that 2s - <time> ~= 0). On slow, or loaded
machines this may fail. Switch this to sleep for 1 second, then have a
tolerance of 0.4s for the deferred resolution.
- Removes a dud return d from testOneWay.
- Remove '*' import & dud 'import random'. This file now passes
pyflakes.
- Strip trailing whitespace
Jira: THRIFT-2657
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
