[
https://issues.apache.org/jira/browse/THRIFT-2664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095637#comment-14095637
]
ASF GitHub Bot commented on THRIFT-2664:
----------------------------------------
GitHub user virtuald opened a pull request:
https://github.com/apache/thrift/pull/188
THRIFT-2664: Resolve method later, prevents errors on oneway functions
https://issues.apache.org/jira/browse/THRIFT-2664
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/virtuald/thrift mainline_recv_method
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/188.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #188
----
commit 4ddbd1fce4a74ec3cb293895fa75b05291e16352
Author: Dustin Spicuzza <[email protected]>
Date: 2014-08-12T21:24:20Z
Resolve method later, prevents errors on oneway functions
----
> Python tornado generated oneway client functions crash on server error
> ----------------------------------------------------------------------
>
> Key: THRIFT-2664
> URL: https://issues.apache.org/jira/browse/THRIFT-2664
> Project: Thrift
> Issue Type: Bug
> Components: Python - Compiler
> Affects Versions: 0.9.1
> Reporter: Dustin Spicuzza
>
> When an exception is thrown on the java server during oneway function
> processing, it appears to send a message back to the client. The java client
> disregards the incoming recv_ call from the server. The tornado bindings
> should do the same thing.
> Without this patch, the incoming response from the server hits the getattr()
> and it crashes because the function does not exist. With this patch, it gets
> discarded correctly, as there isn't a future registered by oneway functions.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
