[
https://issues.apache.org/jira/browse/THRIFT-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Thompson updated THRIFT-1840:
-----------------------------------
Attachment: fix_globals.js
For anyone else that runs into this issue, this is a quick node hack that'll
look in your gen-nodejs directory and insert 'var ' statements and add "use
strict" to the top to notify you of any other bad behavior.
Note that by adding the var statements, if a thrift file requires in
dependencies like this:
var common_ttypes = require('./common_types')
Those types won't be exposed globally anymore like they used to be, so you'll
have to manually require the types that you need to use (as it should be).
> Thrift Generated Code Causes Global Variable Leaks
> --------------------------------------------------
>
> Key: THRIFT-1840
> URL: https://issues.apache.org/jira/browse/THRIFT-1840
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Compiler
> Affects Versions: 0.9
> Reporter: Russell Bradberry
> Labels: javascript, node
> Attachments: 0001-THRIFT-1840-fix-for-global-variable-leak.patch,
> fix_globals.js
>
>
> When compiling for NodeJS, the compiler creates globally scoped variables
> which is considered a bad practice as it can create unintended consequences.
> It also causes many testing frameworks to fail.
> the output looks something like this:
> {code}
> User = module.exports.User = function(args) {
> {code}
> when it should be
> {code}
> var User = module.exports.User = function(args) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
