Github user zilberstein commented on a diff in the pull request:
https://github.com/apache/thrift/pull/190#discussion_r16317049
--- Diff: test/hs/TestClient.hs ---
@@ -197,24 +198,24 @@ main = do
Binary -> runClient $ BinaryProtocol handle
Compact -> runClient $ CompactProtocol handle
JSON -> runClient $ JSONProtocol handle
- replicateM_ testLoops client
+ replicateM_ testLoops client
putStrLn "COMPLETED SUCCESSFULLY"
parseFlags :: [String] -> Options -> Maybe Options
+parseFlags (flag : flags) opts = do
+ let pieces = splitOn "=" flag
+ case pieces of
--- End diff --
1) The pattern match case on line 204/217 should be integrated into the
`case` statement here.
2) You match a couple of strings, but a non-exhaustive pattern match error
will be thrown if none of these strings match. You should add a default case
with the wildcard operator (`_`) that evaluated to `Nothing` so that if you
enter an unsupported flag it will print the help message
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
