GitHub user hcorg opened a pull request:
https://github.com/apache/thrift/pull/210
THRIFT-2692 compiler refactor v2
this pull request contains some 'real' refactoring (of my own previous
contribution) which shows how much adding new tests can help
also I've created some RAII style classes for some code generation (like
IndentGuard or BracketGuard)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hcorg/thrift THRIFT-2692_compiler_refactor_v2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/210.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #210
----
commit f0438983d5d05fb218e8d088191b48f53d8261bd
Author: Konrad Grochowski <[email protected]>
Date: 2014-09-05T10:58:28Z
libgenerate extracted from thrift executable so compiler specific unit
tests can be added
commit ab65f4239e0331f5ab96510efcd2c3d4a9b700f0
Author: Konrad Grochowski <[email protected]>
Date: 2014-09-06T12:20:43Z
compiler: IndentKeeper extracted from t_generator
* tests added for IndentKeeper
* t_generator movd a little bit towards meeting SRP
* IndentKeeper can be reused by lower level generator
(like MethodGenerator)
commit a4d2e8f5d17996d4566bc47cda7f70808a0b831b
Author: Konrad Grochowski <[email protected]>
Date: 2014-09-06T15:26:02Z
compiler: IndentGuard added
will simplify operating on indents
commit 65c4544f018dff8dbbfc6c3337451e4fc1ebf836
Author: Konrad Grochowski <[email protected]>
Date: 2014-09-08T13:45:47Z
compiler: ScopeGuard added
commit 85b180d8085b313eee9b42ddd9368af8b75aa21f
Author: hcorg <[email protected]>
Date: 2014-09-08T18:04:44Z
compiler: C++ generator refactoring started - operator<< generation made
more OO
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
