[
https://issues.apache.org/jira/browse/THRIFT-2711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136326#comment-14136326
]
ASF GitHub Bot commented on THRIFT-2711:
----------------------------------------
GitHub user hcorg opened a pull request:
https://github.com/apache/thrift/pull/218
THRIFT-2711 - proper build result returned from Travis
Travis will properly mark build as failed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hcorg/thrift travis_proper_result
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/218.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #218
----
commit fa8d7ba7386c1bfc2e206639876f3e9d0efa47d9
Author: Konrad Grochowski <[email protected]>
Date: 2014-09-16T18:19:56Z
THRIFT-2711 - proper build result returned from Travis
Travis will properly mark build as failed
----
> master no longer compiles with i586-mingw32msvc
> -----------------------------------------------
>
> Key: THRIFT-2711
> URL: https://issues.apache.org/jira/browse/THRIFT-2711
> Project: Thrift
> Issue Type: Bug
> Components: Build Process, Compiler (General)
> Environment: Travis
> Reporter: Konrad Grochowski
>
> first I've noticed that Travis reports false positive for mingw builds. After
> fixing it (patch will be attached) I checked why it does not compile: some
> thrift compiler code uses C++11 features (which is good imho), but
> i586-mingw32msvc is veeeeery old compiler.
> I started working on patch for Travis to run CI with newer version of cross
> compiler. But maybe i586-mingw32msvc is desired for some special purpose? Is
> it possible to update it?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
