[
https://issues.apache.org/jira/browse/THRIFT-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski resolved THRIFT-2688.
---------------------------------------
Resolution: Later
I agree that solution proposed by [~ben.craig] is better and will solve (if
implemented) my main problem - MSVC warnings :)
> Generating *Null implementations should be optional
> ---------------------------------------------------
>
> Key: THRIFT-2688
> URL: https://issues.apache.org/jira/browse/THRIFT-2688
> Project: Thrift
> Issue Type: New Feature
> Components: C++ - Compiler
> Reporter: Konrad Grochowski
> Attachments: THRIFT-2688.patch
>
>
> *Null implmentations introduce another level of ugly diamond shaped
> inheritance (with extended ifaces), which - among other things - leads to a
> lot of warnings on MSVC ("inheritance via dominance" C4250).
> Additionallly it just clobbers generated header as when stubs are needed
> GoogleMock/Turtle could/should be used.
> But I do understand requirement for backward compatibility, so in attached
> patch I've added option to ommit nulls generation, so still by default
> they'll be generated
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
