Github user captncraig commented on the pull request:

    https://github.com/apache/thrift/pull/177#issuecomment-56225456
  
    Yeah, I agree that scenario sucks. The problem is, I am not sure that all 
of the transports have a way to really do peek. TcpSocket for example only has 
a Read operation. I would then have to do essentially the same code in each 
individual transport to achieve the same effect. As far as I could tell, all of 
the protocol code only calls ReadAll directly.
    
    Maybe it would be better to have to override peek in each individual 
transport, but I was trying to accomplish with as minor a change as possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to