[ 
https://issues.apache.org/jira/browse/THRIFT-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162666#comment-14162666
 ] 

Vitali Lovich commented on THRIFT-2464:
---------------------------------------

My understanding is that it also doesn't participate in code-generation, so if 
I rename a type or namespace, I have to update all the strings too instead of 
getting compile-time checking.

I suggest an extensible mechanism that solves a lot of maintainability issues 
in: https://issues.apache.org/jira/browse/THRIFT-2772

Basically, there's a top-level thrift type called 'type' (sibling to 
message/exception).  This encapsulates the type information (re-usability), 
supports substitution (DRY principle) while allowing the user a mechanism to 
ensure that there aren't typos or forgotten refactor updates.

> Transition cpp_type and cpp_include keywords to compiler annotations
> --------------------------------------------------------------------
>
>                 Key: THRIFT-2464
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2464
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (General)
>    Affects Versions: 0.9.2
>         Environment: C++
>            Reporter: Randy Abernethy
>            Assignee: Randy Abernethy
>            Priority: Minor
>             Fix For: 1.0
>
>
> The cpp_type and cpp_include keywords provide a useful feature but are 
> language specific. In keeping with the trend of moving the interface language 
> to a clean cross implementation language abstraction, these two keywords 
> should be transitioned to annotations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to