[ 
https://issues.apache.org/jira/browse/THRIFT-2779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14164871#comment-14164871
 ] 

ASF GitHub Bot commented on THRIFT-2779:
----------------------------------------

GitHub user llhe opened a pull request:

    https://github.com/apache/thrift/pull/244

    Fix PHP TJSONProtocol encode unicode into UTF8 instead of UCS-4LE

    fix THRIFT-2779.
    JSON_UNESCAPED_UNICODE option is only available for PHP 5.4+.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/llhe/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/244.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #244
    
----
commit 63e2ae1852617207a011d4b68c040beaa6409ff0
Author: Liangliang He <[email protected]>
Date:   2014-10-09T07:31:00Z

    Fix PHP TJSONProtocol encode unicode into UTF8 instead of UCS-4LE

----


> PHP TJSONProtocol encode unicode into UCS-4LE which can't be parsed by other 
> langurage bindings
> -----------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-2779
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2779
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Library
>            Reporter: He Liangliang
>            Priority: Critical
>
> TJSONProtocol serialize string using json_encode which convert unicode 
> character into UCS-4LE format, which can't be accepted by other language 
> bindings, e.g. Java library. The simplest way to fix it is change UCS-4LE 
> encoding to UTF8 encoding.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to