[ 
https://issues.apache.org/jira/browse/THRIFT-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170150#comment-14170150
 ] 

Konrad Grochowski commented on THRIFT-2784:
-------------------------------------------

as a workaround - use -Wpedantic, it'll just generate warning, not an error... 

or change EnumTest.thirft

{code}
enum MyEnum5 {
  // attempting to explicitly use values out of the i32 range will also fail
  // ME5_A = 0x80000000,
  // ME5_B = 0x100000000,
}
{code}

this whole {{MyEnum5}} could be commented out (or even removed - 'expect to 
fail' should be made a unit test inside parser)

> Eliminate compiler warnings in generated C++ code
> -------------------------------------------------
>
>                 Key: THRIFT-2784
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2784
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Compiler
>    Affects Versions: 0.9.1
>            Reporter: John Campbell
>            Assignee: Roger Meier
>            Priority: Minor
>         Attachments: thrift-2784-eliminate_generated_cpp_warnings.patch
>
>
> Generated C++ classes generate compiler warnings when the using code is 
> compiled with -Wall -Wextra -pedantic.
> Specifically, there are two types of warnings in the generated code:
> 1. Exceptions don't call parent constructor
> 2. Unused warnings
> (there may be others in the generated code, however no others have been found 
> at this time)
> Ideally, the generated C++ code should not have these errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to