[
https://issues.apache.org/jira/browse/THRIFT-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brock Noland updated THRIFT-2046:
---------------------------------
Attachment: THRIFT-2046_5.patch
Attached patch addresses the two review items and:
(1) renames "Throwable" variable from "ex" to "t"
(2) in additional to *not* catching OutOfMemoryError, we re-throw all
subclasses of Error as they are not likely to resolve themselves in this
scenario.
{noformat}
+ } else if (t instanceof Error) {
+ LOGGER.error("ExecutorService threw error: " + t, t);
+ throw (Error)t;
{noformat}
> The worktask can be timed out in TThreadPoolServer (Java) when the max#
> thrift thread is reached
> ------------------------------------------------------------------------------------------------
>
> Key: THRIFT-2046
> URL: https://issues.apache.org/jira/browse/THRIFT-2046
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.9
> Reporter: Chaoyu Tang
> Assignee: Jake Farrell
> Fix For: 1.0
>
> Attachments: THRIFT-2046.patch, THRIFT-2046_1.patch,
> THRIFT-2046_2.patch, THRIFT-2046_3.patch, THRIFT-2046_4.patch,
> THRIFT-2046_5.patch
>
>
> Once the max# of thrift threads is reached, a new task (workprocess) is
> attempted to be executed in an infinite loop, then the client may hang.
> An improvement is to introduce a task timeout. after a certain time, if the
> task is still not got queued to be executed. It will be invalidated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
