GitHub user gdecaso opened a pull request:
https://github.com/apache/thrift/pull/257
do not leave the serverSocket_ open if something goes wrong during
construction
If construction of a TServerSocket fails the underlying ServerSocket object
may already have been initialized. Since the reference is nullified, we loose
the opportunity to properly close it. This fix addresses the issue by always
cleaning up after failures during construction.
Additionally, the failure message is added to the exception for improved
visibility of what went wrong
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gdecaso/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/257.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #257
----
commit 3c2de331e310e99c85d092c16334031a276d995e
Author: Guido de Caso <[email protected]>
Date: 2014-11-10T17:32:14Z
do not leave the serverSocket_ open if something goes wrong during
construction
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
