[
https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14208033#comment-14208033
]
Konrad Grochowski edited comment on THRIFT-2729 at 11/12/14 1:47 PM:
---------------------------------------------------------------------
clang-format would force us to change existing style, as not everything is yet
configurable in it.
Example:
{code}
namespace a { namespace b {
{code}
would have to become
{code}
namespace a {
namespace b {
{code}
yet I think that is the only thing requiring change. In my branch for C++V2
I've used it on copy of current lib and most files where not changed (apart
from namespaces).
If we could accept 'namespace change' than reformating via clang-format is
possible,
was (Author: hcorg):
clang-format would force us to change existing style, as not everything is yet
configurable in it.
Example:
{code}
namespace a { namespace b {
{code}
would have to become
{code}
namespace a {
namespace b {
{code}
yet I think that is the only thing requiring change. In my branch for C++V2
I've used it on copy of current lib and most files where not changed.
If we could accept 'namespace change' than reformating via clang-format is
possible,
> C++ coding standards
> --------------------
>
> Key: THRIFT-2729
> URL: https://issues.apache.org/jira/browse/THRIFT-2729
> Project: Thrift
> Issue Type: Sub-task
> Components: C++ - Library
> Reporter: Konrad Grochowski
> Attachments: .clang-format, CPPLINT.cfg
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
