[
https://issues.apache.org/jira/browse/THRIFT-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213293#comment-14213293
]
ASF GitHub Bot commented on THRIFT-2827:
----------------------------------------
GitHub user sectioneight opened a pull request:
https://github.com/apache/thrift/pull/267
THRIFT-2827: Remove unused tr1/functional include
This appears unused and is causing compilation issues on OS X.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sectioneight/thrift THRIFT-2827
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/267.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #267
----
commit ee633a325b3d5d38bebb792d23634b6dd0ccb471
Author: Aiden Scandella <[email protected]>
Date: 2014-11-15T00:49:39Z
THRIFT-2827: Remove unused tr1/functional include
----
> Thrift 0.9.2 fails to compile on Yosemite due to tr1/functional include in
> ProcessorTest.cpp
> --------------------------------------------------------------------------------------------
>
> Key: THRIFT-2827
> URL: https://issues.apache.org/jira/browse/THRIFT-2827
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.9.2
> Environment: OS X Yosemite
> Reporter: Aiden Scandella
>
> I am trying to update the homebrew recipe for OS X to build Thrift 0.9.2. The
> current 0.9.1 formula includes many patches in order to get it building.
> Currently the only error left is in compiling processor/ProcessorTest.cpp
> processor/ProcessorTest.cpp:26:10: fatal error: 'tr1/functional' file not
> found
> #include <tr1/functional>
> ^
> 1 error generated.
> make[4]: *** [processor/ProcessorTest.o] Error 1
> make[3]: *** [all-recursive] Error 1
> make[2]: *** [all-recursive] Error 1
> make[1]: *** [all-recursive] Error 1
> make: *** [all] Error 2
> This file seems to have been added in THRIFT-1336 and is the only file I see
> that still tries to include tr1/functional directly. Ignoring this error
> produces a workable thrift 0.9.2 package without any custom patches.
> Homebrew issue I'm working on is here:
> https://github.com/Homebrew/homebrew/issues/34194
> Is this as simple as swapping out the include for thrift/cxxfunctional.h ? Or
> am I missing something.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
