[
https://issues.apache.org/jira/browse/THRIFT-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randy Abernethy resolved THRIFT-2823.
-------------------------------------
Resolution: Fixed
Committed.
Summary:
PATCH 1: The JS test.html test file was failing because it tried to load
thrift.js from a parent dir of the origin (not allowed by many web servers, we
should avoid .. paths). Patch 1 fixed this allowing the grunt build to run with
all tests successful.
PATCH 2: A completely different problem (created by me) involved the build.xml
copying the lib/js/src/thrift.js to test/build/js incorrectly. This became
evident when the test.html was given the correct lib/js/build/js path to
thrift.js.
Note that make check should probably be running the JS grunt build rather than
the JS ant test. The ant test task runs JS against Java, which should really be
part of make cross. On the todo list.
-Randy
> All JS-tests are failing when run with grunt test
> -------------------------------------------------
>
> Key: THRIFT-2823
> URL: https://issues.apache.org/jira/browse/THRIFT-2823
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Library
> Affects Versions: 0.9.2
> Environment: Browser
> Reporter: David Sautter
> Assignee: Randy Abernethy
> Priority: Minor
> Fix For: 0.9.3
>
> Attachments: 0001-fixed-js-build.xml.patch,
> 0001-repaired-bad-test.html-path-to-thrift.patch
>
>
> If you run the tests for the browser js library by calling "grunt test" as
> described in the README.md, you'll get 12/12 tests failing with the following
> Error message:
> Testing http://localhost:8088/test.html FFFFFFF
> >> global failure
> >> Message: ReferenceError: Can't find variable: Thrift
> >> http://localhost:8088/test.html:38
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
