[
https://issues.apache.org/jira/browse/THRIFT-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214106#comment-14214106
]
Hudson commented on THRIFT-2807:
--------------------------------
SUCCESS: Integrated in Thrift #1354 (See
[https://builds.apache.org/job/Thrift/1354/])
THRIFT-2807 PHP CS Fix (roger: rev 6fb5923711a1ad9e90f7b55f724be5db5e299bbf)
* lib/php/lib/Thrift/Protocol/TMultiplexedProtocol.php
* lib/php/lib/Thrift/Transport/TTransport.php
* lib/php/lib/Thrift/Type/TMessageType.php
* lib/php/lib/Thrift/Transport/TSocketPool.php
* lib/php/lib/Thrift/Protocol/TCompactProtocol.php
* lib/php/lib/Thrift/Transport/TCurlClient.php
* lib/php/lib/Thrift/Factory/TTransportFactory.php
* lib/php/lib/Thrift/Exception/TApplicationException.php
* lib/php/lib/Thrift/Factory/TStringFuncFactory.php
* lib/php/lib/Thrift/Server/TSimpleServer.php
* lib/php/lib/Thrift/Exception/TException.php
* lib/php/test/Test/Thrift/TestValidators.php
* lib/php/lib/Thrift/Protocol/TProtocolDecorator.php
* lib/php/lib/Thrift/Transport/THttpClient.php
* lib/php/lib/Thrift/Factory/TJSONProtocolFactory.php
* lib/php/lib/Thrift/Server/TServerSocket.php
* lib/php/lib/Thrift/StringFunc/TStringFunc.php
* lib/php/lib/Thrift/Factory/TProtocolFactory.php
* lib/php/lib/Thrift/Protocol/TBinaryProtocolAccelerated.php
* lib/php/test/Test/Thrift/Fixtures.php
* lib/php/lib/Thrift/Server/TForkingServer.php
* lib/php/lib/Thrift/ClassLoader/ThriftClassLoader.php
* lib/php/lib/Thrift/StringFunc/Mbstring.php
* lib/php/src/autoload.php
* lib/php/lib/Thrift/Base/TBase.php
* lib/php/lib/Thrift/Protocol/JSON/BaseContext.php
* lib/php/lib/Thrift/Protocol/TBinaryProtocol.php
* lib/php/lib/Thrift/Transport/TFramedTransport.php
* lib/php/lib/Thrift/Protocol/TProtocol.php
* lib/php/lib/Thrift/Factory/TCompactProtocolFactory.php
* lib/php/lib/Thrift/Server/TServer.php
* lib/php/lib/Thrift/Transport/TMemoryBuffer.php
* lib/php/lib/Thrift/Serializer/TBinarySerializer.php
* lib/php/test/Test/Thrift/Protocol/TestTJSONProtocol.php
* lib/php/lib/Thrift/Transport/TSocket.php
* lib/php/lib/Thrift/Type/TType.php
* lib/php/lib/Thrift/Exception/TTransportException.php
* lib/php/lib/Thrift/StringFunc/Core.php
* lib/php/lib/Thrift/Protocol/TJSONProtocol.php
* lib/php/lib/Thrift/Protocol/JSON/LookaheadReader.php
* lib/php/lib/Thrift/Exception/TProtocolException.php
* lib/php/test/Test/Thrift/Protocol/TestBinarySerializer.php
* lib/php/lib/Thrift/Factory/TBinaryProtocolFactory.php
* lib/php/lib/Thrift/Transport/TBufferedTransport.php
* lib/php/test/Test/Thrift/JsonSerialize/JsonSerializeTest.php
* lib/php/lib/Thrift/Protocol/JSON/PairContext.php
* lib/php/src/Thrift.php
* lib/php/lib/Thrift/Type/TConstant.php
* lib/php/lib/Thrift/Server/TServerTransport.php
* lib/php/lib/Thrift/Protocol/JSON/ListContext.php
* lib/php/lib/Thrift/Transport/TPhpStream.php
* lib/php/lib/Thrift/Transport/TNullTransport.php
* lib/php/lib/Thrift/TMultiplexedProcessor.php
* lib/php/src/TStringUtils.php
> PHP Code Style
> --------------
>
> Key: THRIFT-2807
> URL: https://issues.apache.org/jira/browse/THRIFT-2807
> Project: Thrift
> Issue Type: Sub-task
> Components: PHP - Library
> Reporter: Roger Thomas
> Assignee: Roger Meier
> Priority: Minor
>
> The Code Style of the PHP Library is seemingly non-consitent (depending on
> who's been writing it).
> I've proposed a PR (https://github.com/apache/thrift/pull/252) that runs a
> simple php-cs-fixer across the library to amend code style (tabs, bracket
> alignment etc).
> The Travis build has executed and passed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
