[
https://issues.apache.org/jira/browse/THRIFT-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214121#comment-14214121
]
ASF GitHub Bot commented on THRIFT-2831:
----------------------------------------
GitHub user cvlchinet opened a pull request:
https://github.com/apache/thrift/pull/270
THRIFT-2831 - Removes dead code in web_server.js introduced in THRIFT-2819
The commit https://issues.apache.org/jira/browse/THRIFT-2819 introduced
dead code in web_server.js.
Sorry it was introduced by me.
The web_server.js was working totally fine even in binary cases.
My code actually does nothing.
This pull request will remove my changes.
What was I thinking.. ;)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cvlchinet/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/270.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #270
----
commit dfe4653441496d4880183daae94eb32f933dac87
Author: Chi Vinh Le <[email protected]>
Date: 2014-11-16T22:23:50Z
Undo changes in web_server.. it was working perfectly
----
> Removes dead code in web_server.js introduced in THRIFT-2819
> ------------------------------------------------------------
>
> Key: THRIFT-2831
> URL: https://issues.apache.org/jira/browse/THRIFT-2831
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Reporter: Chi Vinh Le
>
> The commit https://issues.apache.org/jira/browse/THRIFT-2819 introduced dead
> code in web_server.js.
> Sorry it was introduced by me.
> The web_server.js was working totally fine even in binary cases.
> My code actually does nothing.
> This pull request will remove it:
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
