[
https://issues.apache.org/jira/browse/THRIFT-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219149#comment-14219149
]
ASF GitHub Bot commented on THRIFT-2844:
----------------------------------------
Github user cameronr commented on the pull request:
https://github.com/apache/thrift/pull/251#issuecomment-63778908
jira issue created.
yes, Browserify returns Uint8arrays, not a generic ArrayBuffer. you can see
the code here:
https://github.com/substack/http-browserify/blob/master/lib/response.js#L108
> Nodejs support broken when running under Browserify
> ---------------------------------------------------
>
> Key: THRIFT-2844
> URL: https://issues.apache.org/jira/browse/THRIFT-2844
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Affects Versions: 0.9.2
> Environment: Browserify
> Reporter: Cameron Ring
>
> When running under Browserify, the NodeJS binding fails when using the HTTP
> transport. This happens because Browserify is returning the response as a
> Uint8Array rather than a Buffer. The fix is straightforward: in
> response.on('data', wrap any Uint8Arrays in a buffer so the types are as
> expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
