[
https://issues.apache.org/jira/browse/THRIFT-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220225#comment-14220225
]
Jens Geyer edited comment on THRIFT-2796 at 11/20/14 11:46 PM:
---------------------------------------------------------------
Hi [~magiconair],
thanks for the patch!
Some comments though:
1. Please move the test from {{test/go}} into {{lib/go/test}}. Don't worry,
that's a common misunderstanding: The {{test}} folder is reserved for the
standard Thrift cross test only. All other tests should be placed under
{{lib/language/test}}
2. The newly added file is lacking the ASF license header.
3. Re the Yosemite and Ubuntu build problems: Please search JIRA for similar
issues. There have been a few fixes in the last days, not sure however whether
or not these cover your particular issue. You may also consider to discuss this
on the mailing list and/or file a separate JIRA ticket.
Overall -1 for this pull request, but please keep contributing.
was (Author: jensg):
Hi [~magiconair],
thanks for the patch!
Some comments though:
1. Please move the test from {{test/go}} into {{lib/go/test}}. Don't worry,
that's a common misunderstanding: The {{test}} folder is reserved for the
standard Thrift cross test only. All other tests should be placed under
{{lib/language/test}}
2. Re the Yosemite and Ubuntu build problems: Please search JIRA for similar
issues. There have been a few fixes in the last days, not sure however whether
or not these cover your particular issue. You may also consider to discuss this
on the mailing list and/or file a separate JIRA ticket.
Overall -1 for this pull request, but please keep contributing.
> Testcase for THRIFT-2793
> ------------------------
>
> Key: THRIFT-2796
> URL: https://issues.apache.org/jira/browse/THRIFT-2796
> Project: Thrift
> Issue Type: Test
> Components: Go - Compiler
> Reporter: Jens Geyer
> Fix For: 1.0
>
>
> Add test for THRIFT-2793 Go compiler produces uncompilable code
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
