These tests have few rules,

Well, that does not mean ... I'd still recommend to follow the model given by any existing tests, simply for the sake of consistency.

Have fun,
JensG



-----Ursprüngliche Nachricht----- From: Jens Geyer
Sent: Friday, November 21, 2014 9:09 PM
To: [email protected]
Subject: Re: How to add language-specific unit tests?

Hi Simon,

the test folder is more or less reserved to house the standard Thrift test
for each language. More or less, because there are a bunch of other standard
test IDL files around, which are broadly used as well, but are not really
related to said test.

All other tests are expected to be placed under lib/language/test. These
tests have few rules, so you can basically implement whatever tests are
needed for that language. You will find that a number of tests are
duplicated by other languages as well, such as the multiplex test, but that
is not mandatory. As long as it builds and runs (or fails showing a problem)
everything is possible.

Have fun,
JensG


-----Ursprüngliche Nachricht----- From: Simon South
Sent: Friday, November 21, 2014 4:55 PM
To: [email protected]
Subject: How to add language-specific unit tests?

Is there an established way to add unit tests specific to a language and
issue, or does anyone have a recommendation on how this should be done (or
not done)?

I'd like to add a unit test for my fix to THRIFT-2832, a bug in the C
(GLib) compiler, but it seems right now each language has only unit tests
written against the .thrift files in the top-level "test" subfolder and not
test cases for specific issues that have been reported.

Is this intentional, or can anyone suggest a good approach (file layout and
etc.) for adding issue-specific test cases for a particular language?

--
*Simon South*
Independent Software Developer
Phone: +1 289 716 9945
Email: [email protected]

Reply via email to