[
https://issues.apache.org/jira/browse/THRIFT-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223405#comment-14223405
]
Chi Vinh Le commented on THRIFT-2851:
-------------------------------------
Ok I see the point now. I stumbled upon it again, because in THRIFT-2502 the
Peek function for iostream_transport got commented out.
There seem to be no support from GO to provide such a function to most of the
transport.
IMHO Only barely used memory_buffer could get a real implementation.
So the question is if we should carry along the Peek() function even though
there will be no real implementation for quiet some time.
Currently the implementation doesn't seem to follow a strict line.
E.g. the transport interface doesn't carry a Peek method and not all transport
implements the Peek function.
I vote for remove, as we gain nothing, and appreciate the differences of having
different language platforms with different abilities.
> Remove strange public Peek() from GO transports
> -----------------------------------------------
>
> Key: THRIFT-2851
> URL: https://issues.apache.org/jira/browse/THRIFT-2851
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Affects Versions: 0.9.2
> Reporter: Chi Vinh Le
> Assignee: Jens Geyer
> Priority: Minor
> Fix For: 0.9.3
>
>
> I've been seeing this public Peek() function in the GO library for a while,
> but
> still cannot figure out any sense to it.
> If there are useless, we can remove them right?
> This PR removes the public Peek() from the implemented transports.
> All tests still pass.
> PR: https://github.com/apache/thrift/pull/283
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
