GitHub user cvlchinet opened a pull request:
https://github.com/apache/thrift/pull/285
Better open/close behavior for StreamTransport.
I use StreamTransport a lot to test functionality locally that otherwise
uses a Socket transport. Current implementation of IsOpen returns always true,
even though after a close, the whole transport is not usable.
This PR implements IsOpen, Open and Close that reflects the internal state
and behaves more similar to other transports like TSocket.
Includes a test case.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cvlchinet/thrift go-closable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/285.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #285
----
commit 1592475aa369a35e93a45f09c154ae2574e4cbd5
Author: Chi Vinh Le <[email protected]>
Date: 2014-11-24T21:13:20Z
Better open/close behavior for StreamTransport.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---