[
https://issues.apache.org/jira/browse/THRIFT-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229132#comment-14229132
]
Jens Geyer commented on THRIFT-2859:
------------------------------------
LGTM, just a few remarks:
- How did you test the schema? [This validator|http://jsonschemalint.com/] is
still at draft 03 and refuses to work with a draft 04 file. Is there some
validator around supporting draft 04?
- {{if()}} statements are typically formatted slightly differently in our code
base. I already fixed that for your patch (not pushed yet), so no need for
action.
- [~roger.meier] and [~captncraig], any comments from your side?
Regarding formatting: Great that we now have somewhat nicer line breaks in the
generated JSON file. I wonder if we could improve readability even more by
adding some indentation (new ticket)? What doy you think?
> JSON generator: output complete descriptors
> -------------------------------------------
>
> Key: THRIFT-2859
> URL: https://issues.apache.org/jira/browse/THRIFT-2859
> Project: Thrift
> Issue Type: Improvement
> Components: JSON - Compiler
> Affects Versions: 0.9.2
> Reporter: Stig Bakken
> Assignee: Jens Geyer
> Priority: Minor
>
> (Someone should probably add a Jira component for the JSON generator.)
> The attached pull request contains some improvements to the JSON generator:
> 1. programs are no longer merged by default, use "--gen json:merge"
> 2. "index" is renamed to "key" for fields to match the compiler's internal
> naming
> 3. types are described in a way that does not require string parsing
> 4. full support for exceptions, unions, namespaces, includes and
> required/optional fields
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
