GitHub user cvlchinet opened a pull request:
https://github.com/apache/thrift/pull/297
Enhance error handling for the Go client
This PR enhances the Go client error handling by the following:
- Check if method name is correct -> if not return
thrift.WRONG_METHOD_NAME
- Check if MessageType is thrift.REPLY or EXCEPTION -> if not return
thrift.INVALID_MESSAGE_TYPE_EXCEPTION
- Checking the sequence id is done before checking the message type
Includes test cases for every error case.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cvlchinet/thrift go-enhance-client-eh2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/297.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #297
----
commit 851923612feafc802ead03565316d0d57c3b1242
Author: Chi Vinh Le <[email protected]>
Date: 2014-12-01T19:14:31Z
Enhance error handling for the Go client
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
