[ 
https://issues.apache.org/jira/browse/THRIFT-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pascal Bach updated THRIFT-2873:
--------------------------------
    Attachment: 
0001v2-Make-TPipe-and-TPipeServer-working-with-unicode-on-w.patch

Based on your feedback I propose the following reworked patch.

> TPipe and TPipeServer don't compile on windows with UNICODE enabled
> -------------------------------------------------------------------
>
>                 Key: THRIFT-2873
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2873
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9.3
>         Environment: Visual Studio 2013
>            Reporter: Pascal Bach
>            Assignee: Roger Meier
>            Priority: Minor
>              Labels: unicode, windows
>         Attachments: 
> 0001-Make-TPipe-and-TPipeServer-working-with-unicode-on-w.patch, 
> 0001v2-Make-TPipe-and-TPipeServer-working-with-unicode-on-w.patch
>
>
> When compiling the Thrift C++ library with {{UNICODE}} enabled {{TPipe}} and 
> {{TPipeServer}} won't compile as the are using {{LPSTR}} which only works 
> with Multi byte charactersets.
> The appended patch uses {{LPTSTR}} instead of {{LPSTR}} which is set based on 
> the {{UNICODE}} flag by Visual Studio.
> It also does some casts from raw {{const char *}} to {{LPCSTR}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to