[
https://issues.apache.org/jira/browse/THRIFT-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238486#comment-14238486
]
Hudson commented on THRIFT-2868:
--------------------------------
SUCCESS: Integrated in Thrift #1395 (See
[https://builds.apache.org/job/Thrift/1395/])
THRIFT-2868 Enhance error handling in the Go client (jensg: rev
1f42d315759a725f9c2846b0996d03128e2f1887)
* lib/go/test/ErrorTest.thrift
* lib/go/test/tests/client_error_test.go
* compiler/cpp/src/generate/t_go_generator.cc
> Enhance error handling in the Go client
> ----------------------------------------
>
> Key: THRIFT-2868
> URL: https://issues.apache.org/jira/browse/THRIFT-2868
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler, Go - Library
> Affects Versions: 0.9.2
> Reporter: Chi Vinh Le
> Assignee: Jens Geyer
> Fix For: 0.9.3
>
>
> The Go client doesn't do proper error checking. E.g. it doesn't check whether
> the received method name is correct nor if the message type has the expected
> value.
> The following PR enhances the Go client error handling by the following:
> - Check if method name is correct -> if not return thrift.WRONG_METHOD_NAME
> - Check if MessageType is thrift.REPLY or EXCEPTION -> if not return
> thrift.INVALID_MESSAGE_TYPE_EXCEPTION
> - Checking the sequence id is done before checking the message type
> Includes test cases for every error case.
> https://github.com/apache/thrift/pull/297
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
