[ 
https://issues.apache.org/jira/browse/THRIFT-2779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245507#comment-14245507
 ] 

ASF GitHub Bot commented on THRIFT-2779:
----------------------------------------

Github user bufferoverflow commented on the pull request:

    https://github.com/apache/thrift/pull/313#issuecomment-66888731
  
    lib/php/test/Test/Thrift/Protocol/TestTJSONProtocol.php:103
    this breaks the test suite *make check* and what about *make cross*
    2) test\Thrift\Protocol\TestTJSONProtocol::testStringMap_Write
    Failed asserting that two strings are equal.



> PHP TJSONProtocol encode unicode into UCS-4LE which can't be parsed by other 
> language bindings
> ----------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-2779
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2779
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: PHP - Library
>            Reporter: He Liangliang
>            Assignee: Jens Geyer
>            Priority: Critical
>             Fix For: 0.9.3
>
>
> TJSONProtocol serialize string using json_encode which convert unicode 
> character into UCS-4LE format, which can't be accepted by other language 
> bindings, e.g. Java library. The simplest way to fix it is change UCS-4LE 
> encoding to UTF8 encoding.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to