[
https://issues.apache.org/jira/browse/THRIFT-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245699#comment-14245699
]
ASF GitHub Bot commented on THRIFT-2890:
----------------------------------------
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/319
THRIFT-2890 binary data may lose bytes with JSON transport under specifi...
...c circumstances
Client: Delphi
Patch: Jens Geyer
This patch consists of a ported version of the base64 encoding/decoding
used in C#. It handles the above case correctly, decodes data more efficiently
in-place, and removes the dependency to Indy (IdCoderMIME).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G/thrift thrift-2890
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/319.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #319
----
commit fc8c93b16c8c936069685f908dcd54c30bd479cc
Author: Jens Geyer <[email protected]>
Date: 2014-12-13T22:44:23Z
THRIFT-2890 binary data may lose bytes with JSON transport under specific
circumstances
Client: Delphi
Patch: Jens Geyer
This patch consists of a ported version of the base64 encoding/decoding
used in C#. It handles the above case correctly, decodes data more efficiently
in-place, and removes the dependency to Indy (IdCoderMIME).
----
> binary data may lose bytes with JSON transport under specific circumstances
> ---------------------------------------------------------------------------
>
> Key: THRIFT-2890
> URL: https://issues.apache.org/jira/browse/THRIFT-2890
> Project: Thrift
> Issue Type: Bug
> Components: Delphi - Library
> Affects Versions: 0.9.1, 0.9.2
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Fix For: 0.9.3
>
>
> The Delphi implementation currently relies on IdCoderMIME for base64
> encoding/decoding, which expects the base64 encoding to be complete with
> padding.
> With Thrift it is legal to transfer binary data via JSON without padding, but
> IdCoderMIME fails to handle this case correctly. Depending on the length of
> the data, up to 2 bytes from the end of a binary data block may get lost.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
