Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/321#issuecomment-67169703
Note that current code uses mixed `#if` and `#ifdef` for `USE_..._Thread`
preprocessor macro tests and I unified those too.
These differs only when macro value is *not* non-zero integer value
which has been resulting in inconsistent, broken configuration.
(For example, with `USE_STD_THREAD=0`
`#if !USE_STD_THREAD` passes whereas
`#ifndef USE_STD_THREAD` does not pass)
I can do it the other way around if there's already a prefered way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
