[
https://issues.apache.org/jira/browse/THRIFT-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248326#comment-14248326
]
ASF GitHub Bot commented on THRIFT-2893:
----------------------------------------
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/321#issuecomment-67169703
Note that current code uses mixed `#if` and `#ifdef` for `USE_..._Thread`
preprocessor macro tests and I unified those too.
These differs only when macro value is *not* non-zero integer value
which has been resulting in inconsistent, broken configuration.
(For example, with `USE_STD_THREAD=0`
`#if !USE_STD_THREAD` passes whereas
`#ifndef USE_STD_THREAD` does not pass)
I can do it the other way around if there's already a prefered way.
> CMake build fails with boost thread or std thread
> -------------------------------------------------
>
> Key: THRIFT-2893
> URL: https://issues.apache.org/jira/browse/THRIFT-2893
> Project: Thrift
> Issue Type: Bug
> Reporter: Nobuaki Sukegawa
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
