[
https://issues.apache.org/jira/browse/THRIFT-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252837#comment-14252837
]
ASF GitHub Bot commented on THRIFT-2880:
----------------------------------------
Github user fumin commented on the pull request:
https://github.com/apache/thrift/pull/310#issuecomment-67592869
Hi Jens
I'm totally sorry if my tone was offensive. By fork, I don't mean to fork
in the general sense, just the common Go practice of maintaining a copy of the
source code in a subfolder. I am not a native speaker and thus I sometimes
don't get the nuances right. : (
Also, thanks a lot for your efforts in maintaining this wonderful library
which we have benefited from a lot. I truly appreciate the work in Thrift!
> Read the network address from the listener if available.
> --------------------------------------------------------
>
> Key: THRIFT-2880
> URL: https://issues.apache.org/jira/browse/THRIFT-2880
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Library
> Affects Versions: 0.9.2
> Environment: Linux Amazon AMI
> Reporter: awaw fumin
> Assignee: Jens Geyer
> Labels: patch
> Fix For: 0.9.3
>
> Attachments:
> 0001-Read-the-network-address-from-the-listener-if-availa.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Often in tests, the listening port of a test server is automatically
> selected by passing the zero port in the host, as in "127.0.0.1:0".
> An example of such behaviour is in the "httptest" package of the
> standard library:
>
> https://github.com/golang/go/blob/master/src/net/http/httptest/server.go#L65
>
> As such, it is necessary to read from the listener itself to retrieve
> the actually listening port, as in
>
> https://github.com/golang/go/blob/master/src/net/http/httptest/server.go#L107
> The pull request that fixes this is https://github.com/apache/thrift/pull/310
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
