[
https://issues.apache.org/jira/browse/THRIFT-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260105#comment-14260105
]
ASF GitHub Bot commented on THRIFT-2878:
----------------------------------------
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/304#issuecomment-68257838
Hi @cvlchinet,
good work! Just one thing: What about changing the test case to use the
existing OptionalRequiredTest.thrift IDL instead of adding a new IDL file?
> Go validation support of required fields
> ----------------------------------------
>
> Key: THRIFT-2878
> URL: https://issues.apache.org/jira/browse/THRIFT-2878
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler, Go - Library
> Affects Versions: 0.9.2
> Reporter: Chi Vinh Le
> Assignee: Jens Geyer
> Fix For: 0.9.3
>
>
> The Go implementation doesn't validate required fields yet.
> This PR adds this validation and includes a test case.
> https://github.com/apache/thrift/pull/304
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
