GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/344
THRIFT-2925 CMake build does not work with OpenSSL nor anything installe...
...d in non-system location
This diff fixes them by correcting invalid CMake variable names:
* OPENSSL_... rather than OpenSSL_...
* LIBEVENT_... rather than Libevent_...
* Boost_INCLUDE_DIRS rather than Boost_INCLUDE_DIR
* LIBEVENT_INCLUDE_DIRS rather than LIBEVENT_INCLUDE_DIR
* ZLIB_INCLUDE_DIRS rather than ZLIB_INCLUDE_DIR
Note:
* OPENSSL_INCLUDE_DIR is correct (rather than ..._DIRS)
* Boost_INCLUDE_DIR exists and actually works for most cases but
Boost_INCLUDE_DIRS is the one desinged to be included
Also, library headers are now included as SYSTEM headers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-2925
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/344.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #344
----
commit f6fc23350f32c4092ed03a95fb36238e07a3342a
Author: Nobuaki Sukegawa <[email protected]>
Date: 2015-01-02T14:16:55Z
THRIFT-2925 CMake build does not work with OpenSSL nor anything installed
in non-system location
This diff fixes them by correcting invalid CMake variable names:
* OPENSSL_... rather than OpenSSL_...
* LIBEVENT_... rather than Libevent_...
* Boost_INCLUDE_DIRS rather than Boost_INCLUDE_DIR
* LIBEVENT_INCLUDE_DIRS rather than LIBEVENT_INCLUDE_DIR
* ZLIB_INCLUDE_DIRS rather than ZLIB_INCLUDE_DIR
Note:
* OPENSSL_INCLUDE_DIR is correct (rather than ..._DIRS)
* Boost_INCLUDE_DIR exists and actually works for most cases but
Boost_INCLUDE_DIRS is the one desinged to be included
Also, library headers are now included as SYSTEM headers.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
