[
https://issues.apache.org/jira/browse/THRIFT-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263580#comment-14263580
]
Hudson commented on THRIFT-2886:
--------------------------------
SUCCESS: Integrated in Thrift #1423 (See
[https://builds.apache.org/job/Thrift/1423/])
THRIFT-2886 Integrate binary type in standard Thrift cross test (jensg: rev
a2d5dfd9f60baf2bf8629b62ba1dde78bcc371b0)
* test/ThriftTest.thrift
THRIFT-2886 Integrate binary type in standard Thrift cross test (jensg: rev
71e814a9a2b7b15cf29c2527e7a81145c01fbde8)
* lib/csharp/test/ThriftTest/TestServer.cs
* lib/csharp/test/ThriftTest/TestClient.cs
THRIFT-2886 Integrate binary type in standard Thrift cross test (jensg: rev
fd1b3585596fdec749372f383208069d0ca1d9b0)
* lib/delphi/test/TestConstants.pas
* lib/delphi/test/TestClient.pas
* lib/delphi/test/codegen/run-Pascal-Codegen-Tests.bat.tmpl
* lib/delphi/test/TestServer.pas
THRIFT-2886 Integrate binary type in standard Thrift cross test (jensg: rev
43e195afcd4cd3db67c7343271920af147e268e6)
* test/haxe/src/TestClient.hx
* test/haxe/src/TestServerHandler.hx
THRIFT-2886 Integrate binary type in standard Thrift cross test (jensg: rev
8bcfdd98ae59d840b677a485b74dda3953b4bcc1)
* lib/d/test/thrift_test_server.d
* test/go/src/bin/testclient/main.go
* lib/erl/test/test_server.erl
* test/php/TestClient.php
* lib/d/test/thrift_test_client.d
* test/c_glib/src/test_client.c
* test/c_glib/src/thrift_test_handler.c
* lib/c_glib/test/testthrifttestclient.cpp
* test/lua/test_basic_client.lua
* lib/js/test/test-async.js
* lib/nodejs/test/thrift_test_driver.js
* test/rb/integration/TestServer.rb
* test/rb/integration/TestClient.rb
* test/cpp/src/TestClient.cpp
* test/perl/TestClient.pl
* test/lua/test_basic_server.lua
* test/go/src/common/simple_handler.go
* lib/go/test/tests/thrifttest_handler.go
* test/hs/TestServer.hs
* test/hs/TestClient.hs
* test/go/src/common/clientserver_test.go
* test/py.twisted/test_suite.py
* test/ocaml/server/TestServer.ml
* test/go/src/common/mock_handler.go
* test/py/TestServer.py
* test/hs/ThriftTest_Main.hs
* test/go/src/common/printing_handler.go
* test/cpp/src/TestServer.cpp
* lib/nodejs/test/thrift_test_driver_promise.js
* test/py.tornado/test_suite.py
* lib/nodejs/test/test_handler.js
* lib/go/test/tests/thrifttest_driver.go
* lib/java/test/org/apache/thrift/test/TestClient.java
* lib/nodejs/test/test_handler_promise.js
* lib/erl/test/test_client.erl
* lib/js/test/test_handler.js
* lib/php/test/Test/Thrift/Fixtures.php
* lib/java/test/org/apache/thrift/server/ServerTestBase.java
* test/py/TestClient.py
> Integrate binary type in standard Thrift cross test
> ---------------------------------------------------
>
> Key: THRIFT-2886
> URL: https://issues.apache.org/jira/browse/THRIFT-2886
> Project: Thrift
> Issue Type: Sub-task
> Components: Test Suite
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Fix For: 0.9.3
>
>
> I propose to complete the half-hearted try to integrate the {{binary}} type
> into the test suite. We actually have a {{CrazyNesting}} struct defined, yet
> that structure is not used in any call. So we do test the code generation
> vis-รก-vis compileability, but we do not test whether or not the
> impleemntation actually works.
> Background info:
> http://stackoverflow.com/questions/27408710/python-thrift-binary-type-requires-encoding
> *Spec proposal:*
> {code}
> /**
> * Prints 'testBinary("%s")' where '%s' is a hex-formatted string of
> thing's data
> * @param binary thing - the binary data to print
> * @return binary - returns the binary 'thing'
> */
> binary testBinary(1: binary thing),
> {code}
> *Test case proposal:*
> The client sends a binary containing all 256 bytes (in arbitrary order) to
> the server and checks the returned binary data against the value sent to the
> server. If they do match exactly, the test counts as passed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
