[
https://issues.apache.org/jira/browse/THRIFT-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263926#comment-14263926
]
ASF GitHub Bot commented on THRIFT-2928:
----------------------------------------
GitHub user bosky101 opened a pull request:
https://github.com/apache/thrift/pull/346
THRIFT-2928 Rename the erlang test_server module
Submitted the fix for the issue I filed earlier today.
Avoiding clashes with the in-built erlang app bundled since November '09
Used git mv, then renamed the module in the source.
Verified that git blame continues to work as expected.
More Details on Jira/THRIFT-2928
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bosky101/thrift THRIFT-2928
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/346.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #346
----
commit b01ecd3a8200cc4ee573cfae41128d8f7c3328b8
Author: Bosky <[email protected]>
Date: 2015-01-04T17:44:11Z
THRIFT-2928 Rename the erlang test_server module
Client: Erlang
Patch: Bhasker Kode
Avoiding clashes with the in-built erlang app bundled since November '09
Used git mv, then renamed the module in the source.
Verified that git blame continues to work as expected.
----
> Rename the erlang test_server module
> ------------------------------------
>
> Key: THRIFT-2928
> URL: https://issues.apache.org/jira/browse/THRIFT-2928
> Project: Thrift
> Issue Type: Improvement
> Components: Erlang - Library
> Reporter: Bhasker Kode
> Priority: Minor
>
> erlang/otp began shipping with an app called *test_server* since November
> 2009 with R13B03. The current version of erlang/otp is approaching R18.
> Thrift's test also comes with test_server.erl at
> {{lib/erl/test/test_server.erl}} as well as a test_client.erl
> after compiling Thrift's erlang modules, I was expecting to find
> {{test_server:go/0}} but instead found functions from
> {{https://github.com/erlang/otp/blob/master/lib/test_server/src/test_server.erl}}
> To avoid such conflicts while developing and in erlang deployments/releases,
> {{test_server.erl}} can be renamed as {{test_thrift_server.erl}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
