Github user radekg commented on the pull request:
https://github.com/apache/thrift/pull/345#issuecomment-68758030
I've done a little bit more research into this. There's a major issue which
will surface in the unit test once I can get it integrated. I've got the test
properly integrated in the grunt task. What happens it that PhantomJS doesn't
like the following expression:
String.fromCharCode.apply(null, new Uint8Array( buffer ) )
This has been described here: https://github.com/mozilla/pdf.js/issues/1955
The problem is, if I apply the "fix" mentioned in the comments, the test
doesn't pass because unicode characters are decoded incorrectly. So, one way or
another, the test will fail. I can see only one solution to this issue. I am
going to close this pull request and provide the ThrifBinaryProtocol for JS as
an external module to be added on top of Thrift library. Once this is done, I
will post a link to the project here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
