[
https://issues.apache.org/jira/browse/THRIFT-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14266995#comment-14266995
]
ASF GitHub Bot commented on THRIFT-2901:
----------------------------------------
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/332#issuecomment-68956159
committed 6d9a3ca7d912482fb1321efae80a07eff9de2b85
please close PR
> Fix for generated TypeScript functions + indentation of JavaScript maps
> -----------------------------------------------------------------------
>
> Key: THRIFT-2901
> URL: https://issues.apache.org/jira/browse/THRIFT-2901
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Compiler
> Affects Versions: 0.9.1
> Reporter: Pascal Schweizer
> Assignee: Roger Meier
> Labels: bug, javascript, typescript
> Fix For: 0.9.3
>
>
> The currently generated TypeScript functions that have no parameters, but
> include a callback, contain an extra comma in the parameter list.
> Example: function(, callback: Function){...}
> This patch fixes this problem and also corrects the indentation for generated
> JavaScript maps, which looked different from the rest.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
