[
https://issues.apache.org/jira/browse/THRIFT-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299203#comment-14299203
]
Andrew de Andrade commented on THRIFT-2964:
-------------------------------------------
Per Randy Abernathy on THRIFT-2933, all the protocols in lib/thrift/protocol.js
and the transports in lib/thrift/transports.js should be broken up into
separate files.
- thrift/lib/nodejs/TBinaryProtocol.js
- thrift/lib/nodejs/TCompactProtocol.js
- thrift/lib/nodejs/TJSONProtocol.js
- thrift/lib/nodejs/TFramedTransport.js
- thrift/lib/nodejs/TBufferedTransport.js
Once this change is made, the functions in lib/thrift/binary.js can be moved to
the protocols that need them. Special attention should be paid to the
readDouble, writeDouble methods since the BinaryProtocol encodes doubles as
big-endian and the CompactProtocol encodes doubles as little-endian.
This change also means that concated and minified code for the browser does not
include protocols that are not used.
For more info, see comments here:
https://issues.apache.org/jira/browse/THRIFT-2933
> nodejs: move protocols and transports into separate files
> ---------------------------------------------------------
>
> Key: THRIFT-2964
> URL: https://issues.apache.org/jira/browse/THRIFT-2964
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Reporter: Andrew de Andrade
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
