[
https://issues.apache.org/jira/browse/THRIFT-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew de Andrade updated THRIFT-2969:
--------------------------------------
Attachment: 0007-nodejs-include-websockets-in-for-each-testAll.sh-loo.patch
0006-Dry-up-nodejs-testAll.sh.-Cover-all-configurations.patch
0005-Clean-up-test-driver-code-some-more.patch
0004-DRY-nodejs-handlers-more.patch
0003-DRY-up-nodejs-test-handlers.patch
0002-DRY-up-nodejs-test-drivers.patch
0001-Consolidated-nodejs-server-client-test-code.patch
These patches together represent a major refactoring of the nodejs library
testing code, eliminating most of the duplication. The testAll.sh script now
tests every possible implementation. There is room for parallelizing these
tests for speed, but that can be the subject of another patch.
I'm trying to move as fast as possible to improve the nodejs code. The sooner
this and my other patches can be reviewed the faster I can contribute more
patches before we hit 1.0.0.
> nodejs: DRY up library tests
> ----------------------------
>
> Key: THRIFT-2969
> URL: https://issues.apache.org/jira/browse/THRIFT-2969
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Reporter: Andrew de Andrade
> Attachments: 0001-Consolidated-nodejs-server-client-test-code.patch,
> 0002-DRY-up-nodejs-test-drivers.patch,
> 0003-DRY-up-nodejs-test-handlers.patch, 0004-DRY-nodejs-handlers-more.patch,
> 0005-Clean-up-test-driver-code-some-more.patch,
> 0006-Dry-up-nodejs-testAll.sh.-Cover-all-configurations.patch,
> 0007-nodejs-include-websockets-in-for-each-testAll.sh-loo.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
