[
https://issues.apache.org/jira/browse/THRIFT-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew de Andrade updated THRIFT-2969:
--------------------------------------
Comment: was deleted
(was: Also, you may want to consider applying patch 0008 after 0001 but before
0002. The reason for this is that patch 0001 changed the interface of
lib/nodejs/test/client.js and lib/nodejs/test/server.js. Those changes in 0001
shouldn't break the cross tests because, in 0001, I use 'tcp' as the default
server type if the {{--type}} flag isn't set and all the cross tests use only
the basic tcp server/client. That said, patch 0008 adds features to the main
test/test.sh file so that cross tests can be tested across all the server types
(tcp, multiplex, http and websocket), but only tcp is enabled for now. )
> nodejs: DRY up library tests
> ----------------------------
>
> Key: THRIFT-2969
> URL: https://issues.apache.org/jira/browse/THRIFT-2969
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Reporter: Andrew de Andrade
> Attachments: 0001-nodejs-Refactor-and-DRY-up-testing-code.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
