I share the concerns Jake has re managing the project as a whole. That"s clearly a big, big plus for the current structure.
Next, I personally found managing a herd of git submodules being a pain. Never tried subtrees, so can't say much to that. However I see the benefits allowing for better integration of forked stuff, as mentioned above. I also see the benefits re being able to pull in only those parts that I need via nuget, npm, haxelib and all the other paket managers, instead of the whole source tree. Question: Where will the cross test be located and how will it be managed? ________________________________ Von: Jake Farrell (JIRA) Gesendet: 04.02.2015 02:13 An: [email protected] Betreff: [jira] [Commented] (THRIFT-2940) Allow installing Thrift from git as NPM module by providing package.json in top level directory [ https://issues.apache.org/jira/browse/THRIFT-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304434#comment-14304434 ] Jake Farrell commented on THRIFT-2940: -------------------------------------- infra side isnt a problem, I can handle all of it. i'm more concerned with the management side of it for us and also dealing with patch submissions across multiple repos as well as the additional burden it will place on releases. Another concern is for a lib like java which is a dependency for a bunch of other repos, not a deal breaker but will need to have some more thought put into splitting it those libraries up (think i have a good solution for it). If it will make it easier for others to do development against and help spread adoption then I am all for it and would be interested in making this occur sooner than later > Allow installing Thrift from git as NPM module by providing package.json in > top level directory > ----------------------------------------------------------------------------------------------- > > Key: THRIFT-2940 > URL: https://issues.apache.org/jira/browse/THRIFT-2940 > Project: Thrift > Issue Type: Improvement > Components: Node.js - Library > Reporter: Radoslaw Gruchalski > Assignee: Roger Meier > > Allow installing thirft from git as NPM module by providing package.json in > top level directory. Currently, result is similar to: > {noformat} > drone:gossiperl-client-js rad$ npm install > npm WARN excluding symbolic link tutorial/erl/client.sh -> server.sh > npm ERR! Error: ENOENT, open > '/var/folders/gd/jkx3kmg53gj85lwjslf79n6m0000gn/T/npm-36445-mmwd9VRJ/1421011402511-0.04021586640737951/package/package.json' > npm ERR! If you need help, you may report this log at: > npm ERR! <http://github.com/isaacs/npm/issues> > npm ERR! or email it to: > npm ERR! <[email protected]> > npm ERR! System Darwin 14.0.0 > npm ERR! command "node" "/usr/local/bin/npm" "install" > npm ERR! cwd /Users/rad/dev/my/gossiperl-client-js > npm ERR! node -v v0.10.22 > npm ERR! npm -v 1.3.14 > npm ERR! path > /var/folders/gd/jkx3kmg53gj85lwjslf79n6m0000gn/T/npm-36445-mmwd9VRJ/1421011402511-0.04021586640737951/package/package.json > npm ERR! code ENOENT > npm ERR! errno 34 > npm ERR! > npm ERR! Additional logging details can be found in: > npm ERR! /Users/rad/dev/my/gossiperl-client-js/npm-debug.log > npm ERR! not ok code 0 > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
