[
https://issues.apache.org/jira/browse/THRIFT-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306062#comment-14306062
]
Randy Abernethy commented on THRIFT-2968:
-----------------------------------------
Hey Andrew,
As you note this patch does not apply yet. I just looked ti over though and
want to flag the fact that as it stands the patch introduces a lot of white
spaces errors. I bring this up not to nit pick but because each white space
error is a diff and it takes everyone longer to figure out where the actual
code changes are. The attached patch has 10 hunks, 8 of which are white space
errors.
-Randy
> nodejs: http connection socket timeout option
> ---------------------------------------------
>
> Key: THRIFT-2968
> URL: https://issues.apache.org/jira/browse/THRIFT-2968
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Reporter: Andrew de Andrade
> Priority: Trivial
> Attachments: 0001-nodejs-http-socket-timeout.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
