Jeremy W. Sherman created THRIFT-2987:
-----------------------------------------

             Summary: TProtocol should return NSString directly rather than by 
reference to appease ARC
                 Key: THRIFT-2987
                 URL: https://issues.apache.org/jira/browse/THRIFT-2987
             Project: Thrift
          Issue Type: Improvement
          Components: Cocoa - Library
            Reporter: Jeremy W. Sherman


As currently written, the compiler gripes like so:

{code}
thrift/lib/cocoa/src/protocol/TBinaryProtocol.m:161:55: warning: method 
parameter of type 'NSString *__autoreleasing *' with no explicit ownership 
[-Wexplicit-ownership-type]
- (void) readMessageBeginReturningName: (NSString **) name
                                                      ^
{code}

Annotating for ownership might make non-ARC builds unhappy, but since there is 
only one object being returned by reference, this and similar methods can just 
be changed to return the name directly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to